fix: tree endpoint should calculate fields grouping by git_commit_hash #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- calculate build_status and test_status grouping by checkouts.git_commit_hash instead of checkouts.id - `git_repository_branch` and `git_commit_name` should come from config - remove fields from the front-end that are no longer related to the tree
mari1912
reviewed
Jul 5, 2024
| @@ -75,7 +75,7 @@ const TreeListingPage = (): JSX.Element => { | |||
| return []; | |||
| } else { | |||
| return((data as Tree[]).map(tree => { | |||
| const fullHash = tree.git_commit_hash ?? tree.patchset_hash ?? ''; | |||
There was a problem hiding this comment.
I'm not sure we should remove this patchset_hash. In most of the cases this will be empty, however, in some cases, where a patchfile is sent instead of a commit, there should be a patchset_hash
There was a problem hiding this comment.
As discussed on our daily patchset_hash will not be used on this page.
mari1912
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git_repository_branchandgit_commit_nameshould come from config