Feat/search tree #55
Merged
Feat/search tree #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mari1912
force-pushed
the
feat/search-tree
branch
from
87da7fa to
4f0ae33
Compare
|
It would be great to have debouncing so that the component doesn't re-render/recalculate data on every keystroke |
|
|
||
| const { data } = useTreeTable(); | ||
|
|
||
| const listItems: TreeTableBody[] = useMemo(() => { | ||
| return data ? (data as Tree[]).map(tree => ({ | ||
| return data ? (data as Tree[]) | ||
| .filter(tree => tree.tree_name?.includes(inputFilter) || tree.git_commit_hash?.includes(inputFilter) || tree.patchset_hash?.includes(inputFilter) || tree.git_repository_branch?.includes(inputFilter)) |
There was a problem hiding this comment.
nit: i would just break in multiple lines to make it easier to read
viniciuslacerda0
approved these changes
Jul 4, 2024
mari1912
force-pushed
the
feat/search-tree
branch
2 times, most recently
from
e8b9f23 to
b386a57
Compare
mari1912
force-pushed
the
feat/search-tree
branch
from
b386a57 to
1cfeb30
Compare
lfjnascimento
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues