Feat: connect api with dashboard #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mari1912
force-pushed
the
feat/connect-api-dashboard
branch
from
538ed5f to
dda3bd9
Compare
lfjnascimento
force-pushed
the
feat/add_tree_endpoint
branch
2 times, most recently
from
b320a7c to
d176e45
Compare
mari1912
force-pushed
the
feat/connect-api-dashboard
branch
2 times, most recently
from
4f887bb to
fa28899
Compare
| <TableCell><div className={backgroundClassName}>{row.buildStatus}</div></TableCell> | ||
| <TableCell> | ||
| <div className={backgroundClassName}> | ||
| {row.testStatus + " "} |
| @@ -24,22 +20,27 @@ const treeTableColumnsLabelId = [ | |||
| 'treeTable.test' | |||
| ]; | |||
|
|
|||
| const TreeTableRow = (row: ITreeTableBody): JSX.Element => { | |||
| const TreeTableRow = (row: TreeTableBody): JSX.Element => { | |||
| const backgroundClassName = "bg-lightGray w-fit h-fit p-1 rounded-lg"; | |||
There was a problem hiding this comment.
since this won't change, you could move it to a global scope
dashboard/src/api/Tree.tsx
Outdated
| const fetchTreeCheckoutData = async(): Promise<Checkout[]> => { | ||
| const res = await fetch('/api/tree'); | ||
| if (!res.ok) { | ||
| throw new Error('Network response was not ok'); |
There was a problem hiding this comment.
Can we be more specific? maybe Request to /api/tree response was not ok
| @@ -54,7 +56,19 @@ const TableInfo = ({ | |||
| }; | |||
|
|
|||
| const TreeMonitorListingPage = (): JSX.Element => { | |||
| const listItems = treeTableRows; | |||
|
|
|||
| const { data } = useTreeTable(); | |||
There was a problem hiding this comment.
Hmm.. I'm trying to think of a name that makes it clearer what useTreeTable is for 🤔
dashboard/src/components/TreeMonitorListingPage/TreeMonitorListingPage.tsx
Outdated
Show resolved
Hide resolved
dashboard/src/components/TreeMonitorListingPage/TreeMonitorListingPage.tsx
Outdated
Show resolved
Hide resolved
| onClickBack={onClickGoBack} | ||
| onClickForward={onClickGoForward} | ||
| /> | ||
| <TableInfo |
There was a problem hiding this comment.
TableInfo is showing text in white color which is very hard to see given our background color
- add checkout type - add tree table body commmon type
- create a query client - add query client provider to app - add use query to get data from tree api
- use data returned from api - remove mocked list
- disable back/forward button when there is no more data to show - separate the filter button in a const - fix end index that is show closes #20
mari1912
force-pushed
the
feat/connect-api-dashboard
branch
from
fa28899 to
7cd4711
Compare
lfjnascimento
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Visual reference