Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: database container #46

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Fix: database container #46

merged 3 commits into from
Jul 3, 2024

Conversation

mari1912
Copy link
Collaborator

@mari1912 mari1912 commented Jul 3, 2024

Description

  • Allow us to access the proper database
  • To run it, use the instructions on README

Issues Related

@mari1912 mari1912 force-pushed the fic/compose-db branch 2 times, most recently from e01f3bd to 47af62c Compare July 3, 2024 14:45
mari1912 added 3 commits July 3, 2024 12:06
- connect it with google cloud proxy auth
- adjust it to use kcidb playground database
@mari1912 mari1912 self-assigned this Jul 3, 2024
@mari1912 mari1912 requested a review from lfjnascimento July 3, 2024 15:08
@mari1912 mari1912 marked this pull request as ready for review July 3, 2024 15:08
@mari1912 mari1912 changed the title Fic/compose db Fix: database container Jul 3, 2024
\"PORT\": \"${DB_DEFAULT_PORT:=5432}\",
\"CONN_MAX_AGE\": ${DB_DEAFULT_CONN_MAX_AGE:=null},
\"OPTIONS\": {
\"connect_timeout\": ${DB_DEFAULT_TIMEOUT:=2}
\"connect_timeout\": ${DB_DEFAULT_TIMEOUT:=16}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is really needed? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just to be sure, sometimes the connection with db can be slow

@mari1912 mari1912 merged commit 1d3be64 into main Jul 3, 2024
8 checks passed
@mari1912 mari1912 deleted the fic/compose-db branch July 3, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: database container
2 participants