add docker services #15
Conversation
lfjnascimento
force-pushed
the
feat/add_docker_files
branch
2 times, most recently
from
5540160 to
16ef288
Compare
lfjnascimento
force-pushed
the
feat/add_docker_files
branch
3 times, most recently
from
a835f45 to
95de0ce
Compare
backend/poetry.lock
Outdated
There was a problem hiding this comment.
why we are adding this file? the poetry.toml ahould be enough
There was a problem hiding this comment.
it is equivalent to package-lock.json, that is, it guarantees the precise installation of dependency versions, so for stability we must include it in versioning as well
| @@ -9,6 +9,8 @@ readme = "README.md" | |||
| python = "^3.10" | |||
| django = "^5.0.6" | |||
| djangorestframework = "^3.15.2" | |||
| gunicorn = "^22.0.0" | |||
There was a problem hiding this comment.
we will use gunicorn as a server for the Django application
There was a problem hiding this comment.
but the django already have a server I think, it's just run poetry run python3 manage.py run server
There was a problem hiding this comment.
Django server is a dev-only tool that make the development straight forward, it is not a "real server"
There was a problem hiding this comment.
why we don't use a .env file?
There was a problem hiding this comment.
Oops, this shouldn't be here. This is a docker solution for secrets, you can read more about it in this doc
lfjnascimento
force-pushed
the
feat/add_docker_files
branch
5 times, most recently
from
97941ce to
02c46bc
Compare
| exit 0 | ||
| fi | ||
|
|
||
| exec gunicorn kernelCI.wsgi:application "$@" |
There was a problem hiding this comment.
we should run django here, not gunicorn poetry run python3 manage.py run server`
- add get_json env_var, a function that looks for environment variables that can be in json format or not; - use get_json_env_var to set ALLOWED_HOSTS. # Please enter the commit message for your changes. Lines starting
lfjnascimento
force-pushed
the
feat/add_docker_files
branch
from
02c46bc to
28089bb
Compare
Description
Add docker-compose.yml creating 3 services:
Related Issues
How to test it
Create secret files:
mkdir -p backend/runtime/secrets uuidgen > backend/runtime/secrets/postgres_password_secretStartup the services with
Make a request to the proxy, it should return the default Django content as we don't have any custom endpoints for now