Feat: accordion build item content #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mari1912
force-pushed
the
feat/table-build-page
branch
from
6f84d3a to
5c3fe08
Compare
Comment on lines
+102
to
+105
| const AccordionBuildsTrigger = ({ | ||
| accordionData, | ||
| }: IAccordionItems): JSX.Element => { | ||
| const triggerInfo = accordionData as AccordionItemBuilds; |
There was a problem hiding this comment.
Its a good pratice to avoid the use of as when possible since it really force the type don't matter what. We could create another type or do:
const AccordionBuildsTrigger = ({
accordionData,
}: {
accordionData: AccordionItemBuilds;
}): JSX.Element => {| ? [ | ||
| { | ||
| value: contentData.testStatus?.passTests ?? 0, | ||
| label: 'Test Success', |
| color: Colors.Gray, | ||
| }, | ||
| ] | ||
| : [{ value: 1, label: 'None', color: Colors.Gray }]; |
There was a problem hiding this comment.
why value: 1 and label: 'None?
mari1912
force-pushed
the
feat/table-build-page
branch
2 times, most recently
from
138ec6f to
650844c
Compare
Comment on lines
113
to
118
| <LinkWithIcon | ||
| title={<FormattedMessage id="buildAccordion.kernelConfig" />} | ||
| icon={<MdFolderOpen className="text-lightBlue" />} | ||
| link={kernelConfig} | ||
| linkText={<FormattedMessage id="buildAccordion.kernelConfigPath" />} | ||
| /> |
There was a problem hiding this comment.
We could make LinksGroup receive an array of objects containing title, link e linkText. Thais way LinksGroup becomes more general and reusable
| @@ -40,7 +40,7 @@ const CardContent = ({ card }: ICardContent): JSX.Element => { | |||
| /> | |||
| ); | |||
| } else if (card.type === 'chart') { | |||
| return <StatusChartMemoized {...card} />; | |||
| return <StatusChartMemoized {...card} title={<></>} />; | |||
There was a problem hiding this comment.
it would be better to make the title optional
mari1912
force-pushed
the
feat/accordion-content-build
branch
from
403ac75 to
72fe214
Compare
mari1912
force-pushed
the
feat/accordion-content-build
branch
2 times, most recently
from
655d4ce to
31908a6
Compare
lfjnascimento
approved these changes
Jul 19, 2024
mari1912
force-pushed
the
feat/accordion-content-build
branch
from
31908a6 to
da4fc95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Visual reference