Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add filter capabilities to the treeDetails endpoint #103

Merged
merged 3 commits into from
Jul 18, 2024
Merged

feat: add filter capabilities to the treeDetails endpoint #103

merged 3 commits into from
Jul 18, 2024

Conversation

lfjnascimento
Copy link
Contributor

@lfjnascimento lfjnascimento commented Jul 18, 2024 •
edited
Loading

Description

now we can use ?filter_<field_name>=<value> to filter the response

How to test it

  • run the backend server with python manage.py runserver (or by using docker compose)
  • make a request using a filter queryparam curl --location 'http://localhost:8000/api/tree/22a40d14b572deb80c0648557f4bd502d7e83826?filter_git_repository_branch=master'

@lfjnascimento lfjnascimento force-pushed the feat/add_filter_to_enpoint branch from 8a60e82 to 3835f48 Compare July 18, 2024 17:01
@lfjnascimento lfjnascimento changed the title gpfFeat/add filter to enpoint feat: add filter capabilities to the treeDetails endpoint Jul 18, 2024
@lfjnascimento lfjnascimento requested a review from mari1912 July 18, 2024 17:03
@lfjnascimento lfjnascimento self-assigned this Jul 18, 2024
@lfjnascimento lfjnascimento marked this pull request as ready for review July 18, 2024 17:03
mari1912
mari1912 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@mari1912 mari1912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only thing that is missing is some tests info that we will need with more details

@lfjnascimento lfjnascimento merged commit 3835f48 into main Jul 18, 2024
8 checks passed
@lfjnascimento lfjnascimento deleted the feat/add_filter_to_enpoint branch July 18, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mari1912 mari1912 mari1912 approved these changes

Assignees

@lfjnascimento lfjnascimento

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfjnascimento @mari1912