feat: add filter to TreeDetailsPage #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfjnascimento
force-pushed
the
feat/add_filter_to_treedetails
branch
4 times, most recently
from
5a2c8cd to
8f08491
Compare
lfjnascimento
changed the title
lfjnascimento
force-pushed
the
feat/add_filter_to_treedetails
branch
from
8f08491 to
dae99d0
Compare
mari1912
approved these changes
Jul 19, 2024
Comment on lines
8
to
16
| branch: 'Branch', | ||
| status: 'Status', | ||
| configs: 'Configs', | ||
| architecture: 'Architecture', | ||
| timing: 'Timing', |
There was a problem hiding this comment.
nit: whenever is possible I think it is better to follow alphabetical order
Comment on lines
47
to
62
| branchSubtitle: 'Please select one or more Branches:', | ||
| statusSubtitle: 'Please select one or more Status:', | ||
| configsSubtitle: 'Please select one or more configs:', | ||
| architectureSubtitle: 'Please select one or more Architectures:', | ||
| timingSubtitle: 'Please select a range of timing:', |
Comment on lines
+124
to
+126
| { title: 'Tree', value: 'stable-rc' }, | ||
| { title: 'Matainer', value: '' }, | ||
| { title: 'Estimate to complete', value: '' }, |
There was a problem hiding this comment.
this values should be using i18n
There was a problem hiding this comment.
actually this should come from the backend, I will implement this soon
lfjnascimento
force-pushed
the
feat/add_filter_to_treedetails
branch
2 times, most recently
from
2a77eaf to
ccb6690
Compare
- also add two filed in type TreeDetailsBuild - git_repository_branch: string; - git_repository_url: string;
- make onRefresh, onCancel and onFilter optional in Drawer - fix open drawer button label
lfjnascimento
force-pushed
the
feat/add_filter_to_treedetails
branch
from
ccb6690 to
d69a9e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add filter to TreeDetailsPage
How to test it
Visual reference