Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reflow issue in storybook example #5589

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix reflow issue in storybook example #5589

merged 1 commit into from
Jan 22, 2025

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Jan 22, 2025

Closes https://github.com/github/accessibility-audits/issues/10014

Before:

Buttons overflows horizontally

After:

Buttons wrap to next line

Changelog

Changed

  • Use the Stack component with flex wrap enabled so that the buttons wrap and don't require two dimensional scrolling with Zoom.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: ce0cb37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@khiga8 khiga8 added the skip changeset This change does not need a changelog label Jan 22, 2025
@khiga8 khiga8 marked this pull request as ready for review January 22, 2025 18:41
@khiga8 khiga8 requested a review from a team as a code owner January 22, 2025 18:41
@khiga8 khiga8 requested a review from camertron January 22, 2025 18:41
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.47 KB (0%)
packages/react/dist/browser.umd.js 104.76 KB (0%)

@khiga8 khiga8 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit bd405df Jan 22, 2025
49 of 50 checks passed
@khiga8 khiga8 deleted the kh-fix-reflow-issue branch January 22, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants