Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ButtonBase): update selector to have specificty 0,1,0 #5584

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor(ButtonBase): update selector to have specificty 0,1,0 #5584

wants to merge 2 commits into from
+12 −7

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jan 21, 2025 •
edited
Loading

Closes https://github.com/github/primer/issues/4703

Changelog

New

Changed

  • Update .ButtonBase to have specificity of at least 0,1,0 to no longer get overridden by reset styles or equivalent selectors with 0,1,0 specificity

Removed

Rollout strategy

  • Patch release

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c0cbbd4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5584 January 21, 2025 21:43 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.25 KB (0%)
packages/react/dist/browser.umd.js 104.56 KB (0%)

langermank
langermank reviewed Jan 21, 2025
View reviewed changes
packages/react/src/Button/ButtonBase.module.css
@@ -98,7 +98,7 @@

/* Button layout */

& .ButtonContent {
& :where(.ButtonContent) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect .ButtonContent and .Label don't need where 🤔 just a variant of ButtonBase right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@langermank honestly just did this to keep the specificity the same but have no idea if it's needed 🤷

Specifically right now this would be: :where(.ButtonBase) .ButtonContent at 0,1,0 and without the :where it would be 0,2,0 with .ButtonBase .ButtonContent.

Would it be helpful if I did not include :where() for descendant selectors unless we see a problem during testing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh okay, no, I think that's fair. Carry on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @langermank