Skip to content

Commit

Permalink
Fix borderColor-closed-muted and revert open colors to orange in prot…
Browse files Browse the repository at this point in the history
…anopia-deuteranopia (#1154)

* add overwrite for borderColor-closed-muted in Dark Protanopia

* update borderColor, fgColor & bgColor open for dark & light protanopia-deuteranopia

* github-actions[bot] Regenerated snapshots

---------

Co-authored-by: lukasoppermann <[email protected]>
  • Loading branch information
lukasoppermann and lukasoppermann authored Jan 20, 2025
1 parent 20b3dda commit f86174b
Show file tree
Hide file tree
Showing 12 changed files with 35 additions and 4 deletions.
10 changes: 10 additions & 0 deletions .changeset/famous-masks-itch.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
'@primer/primitives': patch
---

Fix borderColor-closed-muted in dark-protanopia-deuteranopia and revert protanopia-deuteranopia open color to be orange again

- `borderColor-closed-muted` in dark-protanopia-deuteranopia is now `gray` instead of `orange`
- `borderColor-open-[muted|emphasis]` in protanopia-deuteranopia is now `orange` again (instead of `blue`)
- `fgColor-open` in protanopia-deuteranopia is now `orange` again (instead of `blue`)
- `bgColor-open-[muted|emphasis]` in protanopia-deuteranopia is now `orange` again (instead of `blue`)
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions src/tokens/functional/color/bgColor.json5
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,11 @@
$value: '{base.color.red.4}',
alpha: 0.1,
},
'light-protanopia-deuteranopia': '{base.color.orange.0}',
'dark-protanopia-deuteranopia': {
$value: '{base.color.orange.4}',
alpha: 0.1,
},
},
},
},
Expand All @@ -318,6 +323,8 @@
'org.primer.overrides': {
'light-tritanopia': '{base.color.red.5}',
'dark-tritanopia': '{base.color.red.5}',
'light-protanopia-deuteranopia': '{base.color.orange.5}',
'dark-protanopia-deuteranopia': '{base.color.orange.5}',
},
},
},
Expand Down
14 changes: 14 additions & 0 deletions src/tokens/functional/color/borderColor.json5
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,14 @@
$value: '{base.color.red.3}',
alpha: 0.4,
},
'dark-protanopia-deuteranopia': {
$value: '{base.color.orange.4}',
alpha: 0.4,
},
'light-protanopia-deuteranopia': {
$value: '{base.color.orange.3}',
alpha: 0.4,
},
},
},
},
Expand All @@ -297,6 +305,8 @@
'org.primer.overrides': {
'dark-tritanopia': '{base.color.red.5}',
'light-tritanopia': '{base.color.red.5}',
'dark-protanopia-deuteranopia': '{base.color.orange.5}',
'light-protanopia-deuteranopia': '{base.color.orange.5}',
},
},
},
Expand Down Expand Up @@ -470,6 +480,10 @@
$value: '{borderColor.default}',
alpha: 0.4,
},
'dark-protanopia-deuteranopia': {
$value: '{borderColor.default}',
alpha: 0.4,
},
'light-protanopia-deuteranopia': {
$value: '{borderColor.default}',
alpha: 0.4,
Expand Down
4 changes: 2 additions & 2 deletions src/tokens/functional/color/fgColor.json5
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@
},
},
'org.primer.overrides': {
"dark-protanopia-deuteranopia": '{base.color.blue.3}',
'light-protanopia-deuteranopia': '{base.color.blue.5}',
"dark-protanopia-deuteranopia": '{base.color.orange.4}',
'light-protanopia-deuteranopia': '{base.color.orange.5}',
"dark-tritanopia": '{base.color.red.4}',
"light-tritanopia": '{base.color.red.5}',
},
Expand Down

0 comments on commit f86174b

Please sign in to comment.