Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add an example page #4

Closed
wants to merge 3 commits into from
Closed

Docs: Add an example page #4

wants to merge 3 commits into from

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Feb 13, 2024

This PR adds an example demo page to showcase how this element can be used and to give consumers an example to interact with.

I've found the example pages that have been set up for our other custom elements helpful example: auto-check-element, so wanted to add one for this too!

Changelog

New

Changed

Removed

Testing & Reviewing

Copy link
Contributor Author

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshblack Gonna close this since it was pulled into #5, but I did have a question!

@@ -83,5 +83,16 @@ function getTemplate() {
return template
}

declare global {
Copy link
Contributor Author

@khiga8 khiga8 Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to access the utility methods on the custom element without this declaration/definition which I noticed our other custom elements (e.g. x_banner, and others) have.

Should this be on the consumer to define when they consume the component?

@khiga8
Copy link
Contributor Author

khiga8 commented Feb 14, 2024

pulled into #5

@khiga8 khiga8 closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant