New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README suggestions #3

Merged

joshblack merged 2 commits into main from kh-readme-suggestions

Feb 9, 2024

Contributor

khiga8 commented Feb 9, 2024

Just have a few minor README suggestions:

40f9158 - Updating to not hard-wrap the text. I believe hard wrapping might result in unexpected breaks in screen reader announcements. There is a word wrap setting in VSCode that can be useful for wrapping.
21a36ed - Suggestion to specify default announce, and use as global live region.

This is SO awesome! Thank you for getting this going!

khiga8 added 2 commits

February 9, 2024 15:16


          Don't hard wrap

40f9158


          Note on default, and using as global live region

21a36ed

khiga8 requested a review from joshblack

February 9, 2024 20:32

joshblack approved these changes

View reviewed changes

Member

joshblack left a comment

🔥 Looks great! Thanks 🙏

joshblack merged commit b6d47ac into main

6 checks passed

joshblack deleted the kh-readme-suggestions branch

February 9, 2024 20:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet