-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): update usage for v36 of @primer/react #689
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it myself but, I trust you with these changes!
@siddharthkp sadly I think there are still some styling hiccups left 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very tricky 😭 I see the style issues and differences on my local. Would it help is we gradually increase @primer/react
versions? 🤔 I don't know if that would help but just a thought.
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
Our build is currently failing in
main
due to some issues with updates to dependencies (namely@primer/react
andstyled-components
).This PR updates issues related to
@primer/react
and downgradesstyled-components
to v5 due to a styling bug present in v6.