Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): update usage for v36 of @primer/react #689

Closed
wants to merge 2 commits into from

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Nov 9, 2023

Our build is currently failing in main due to some issues with updates to dependencies (namely @primer/react and styled-components).

This PR updates issues related to @primer/react and downgrades styled-components to v5 due to a styling bug present in v6.

Copy link

changeset-bot bot commented Nov 9, 2023

⚠️ No Changeset found

Latest commit: fc08b24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack marked this pull request as ready for review November 9, 2023 18:46
@joshblack joshblack requested review from a team and siddharthkp November 9, 2023 18:46
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it myself but, I trust you with these changes!

@joshblack
Copy link
Member Author

@siddharthkp sadly I think there are still some styling hiccups left 😅

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very tricky 😭 I see the style issues and differences on my local. Would it help is we gradually increase @primer/react versions? 🤔 I don't know if that would help but just a thought.

Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 12, 2024
@github-actions github-actions bot closed this Jan 19, 2024
@github-actions github-actions bot deleted the fix/update-component-usage-for-v36 branch January 19, 2024 09:02
@joshblack joshblack restored the fix/update-component-usage-for-v36 branch January 19, 2024 16:12
@joshblack joshblack reopened this Jan 19, 2024
@github-actions github-actions bot closed this Jan 26, 2024
@github-actions github-actions bot deleted the fix/update-component-usage-for-v36 branch January 26, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants