Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leadingComponent slot to section intro component #878

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Jan 6, 2025

Summary

Closes https://github.com/github/primer/issues/4582
Part of https://github.com/github/primer/issues/4601

🔗 Preview

List of notable changes:

  • Adds leadingComponent slot
  • Adds Storybook example
  • Adds test coverage (unit + visual)

What should reviewers focus on?

  • Code review

Steps to test:

  1. Review Storybook example

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Screenshot 2025-01-06 at 11 52 02

Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: 1fabfb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 6, 2025

🟢 No design token changes found

@rezrah rezrah marked this pull request as ready for review January 6, 2025 11:55
Copy link
Contributor

github-actions bot commented Jan 6, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah requested a review from natalie-iv January 7, 2025 10:19
Copy link
Contributor

@danielguillan danielguillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rezrah rezrah merged commit d918379 into main Jan 8, 2025
16 of 17 checks passed
@rezrah rezrah deleted the rezrah/leading-component-sectionintro branch January 8, 2025 16:35
@primer-css primer-css mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants