Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Danger support #267

Open
wants to merge 124 commits into
base: master
Choose a base branch
from
Open

Conversation

FlaviuExtPrimer
Copy link
Contributor

@FlaviuExtPrimer FlaviuExtPrimer commented Feb 3, 2025

Adds Danger support in the CI

  • Add danger-kotlin support: checks for tests and runs Detekt
  • Add danger-swift support: dangerfile borrowed from native iOS, checks for tests and runs Swiftlint
  • Add danger-js support: runs eslint, checks WIP PR, checks PR name (conventional commit compatibility), assignees, PR size.
  • Re-runs linters
  • Upgrades ESLint to v9, migrates deprecated ESLint config to new format

Copy link

github-actions bot commented Feb 3, 2025

Appetize Android link: https://appetize.io/app/ldoy5jrl6phuvvwa3yhskkajcu

Base automatically changed from style/ACC-4791/add-lint-support to master February 7, 2025 13:38
…danger

# Conflicts:
#	packages/example/ios/example_0_70_6.xcodeproj/project.pbxproj
#	packages/example/metro.config.js
#	packages/example/package.json
#	packages/example/src/App.tsx
#	packages/example/src/components/Section.tsx
#	packages/example/src/components/TextField.tsx
#	packages/example/src/helpers/helpers.ts
#	packages/example/src/models/IClientSessionRequestBody.ts
#	packages/example/src/network/APIVersion.ts
#	packages/example/src/network/Environment.ts
#	packages/example/src/network/api.ts
#	packages/example/src/screens/CheckoutScreen.tsx
#	packages/example/src/screens/HeadlessCheckoutKlarnaScreen.tsx
#	packages/example/src/screens/HeadlessCheckoutScreen.tsx
#	packages/example/src/screens/HeadlessCheckoutStripeAchScreen.tsx
#	packages/example/src/screens/HeadlessCheckoutVaultScreen.tsx
#	packages/example/src/screens/HeadlessCheckoutWithRedirect.tsx
#	packages/example/src/screens/NewLineItemSreen.tsx
#	packages/example/src/screens/RawAdyenBancontactCardScreen.tsx
#	packages/example/src/screens/RawCardDataScreen.tsx
#	packages/example/src/screens/RawPhoneNumberScreen.tsx
#	packages/example/src/screens/RawRetailOutletScreen.tsx
#	packages/example/src/screens/ResultScreen.tsx
#	packages/example/src/screens/SettingsScreen.tsx
#	packages/example/src/styles.tsx
#	packages/sdk/android/src/main/java/com/primerioreactnative/datamodels/PrimerSettingsRN.kt
#	packages/sdk/ios/Sources/DataModels/PrimerSettings+Extensions.swift
#	packages/sdk/ios/Sources/Helpers/UIColor+Extensions.swift
#	packages/sdk/package.json
#	packages/sdk/src/HeadlessUniversalCheckout/Managers/PaymentMethodManagers/AchManager.ts
#	packages/sdk/src/HeadlessUniversalCheckout/Managers/PaymentMethodManagers/ComponentWithRedirectManager.ts
#	packages/sdk/src/HeadlessUniversalCheckout/Managers/PaymentMethodManagers/KlarnaManager.ts
#	packages/sdk/src/HeadlessUniversalCheckout/Managers/PaymentMethodManagers/RawDataManager.ts
#	packages/sdk/src/HeadlessUniversalCheckout/Managers/VaultManager.ts
#	packages/sdk/src/HeadlessUniversalCheckout/PrimerHeadlessUniversalCheckout.ts
#	packages/sdk/src/Primer.ts
#	yarn.lock
@FlaviuExtPrimer FlaviuExtPrimer marked this pull request as ready for review February 7, 2025 16:41
@FlaviuExtPrimer FlaviuExtPrimer requested a review from a team as a code owner February 7, 2025 16:41
@FlaviuExtPrimer
Copy link
Contributor Author

  • validated by iOS devs

Copy link

github-actions bot commented Feb 7, 2025

Warnings
⚠️ Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PRs for a faster, easier review.
⚠️ Please assign someone aside from CODEOWNERS (@checkout-pci-reviewers) to review this PR.
Messages
📖 ✅ No ESLint violations found.

Generated by 🚫 dangerJS against 4678cd7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant