Update README #364
Merged
Update README #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TheMatten
commented
Jul 21, 2020
•
TheMatten
commented
- fix Update readme with more accurate performance and comparison details #358
- apply some lint suggestions, try to fit 80 characters limit used in other files
- change formatting to make things slightly more readable
- fix links pointing to old URL and stuff
googleson78
reviewed
Jul 21, 2020
googleson78
reviewed
Jul 21, 2020
googleson78
reviewed
Jul 21, 2020
googleson78
reviewed
Jul 21, 2020
googleson78
reviewed
Jul 21, 2020
googleson78
reviewed
Jul 21, 2020
googleson78
reviewed
Jul 21, 2020
isovector
reviewed
Jul 21, 2020
| {-# LANGUAGE TemplateHaskell #-} | ||
| {-# LANGUAGE LambdaCase, BlockArguments #-} | ||
| {-# LANGUAGE GADTs, FlexibleContexts, TypeOperators, DataKinds, PolyKinds #-} | ||
| {-# LANGUAGE TemplateHaskell, LambdaCase, BlockArguments, GADTs |
There was a problem hiding this comment.
this example isn't very helpful, really
There was a problem hiding this comment.
Hmm, maybe it's good to have "dumb" example first, not doing much more than interpreting simple effect, as a sort of showcase of mkSem and interpret.
There was a problem hiding this comment.
Should I keep it as it is?
isovector
approved these changes
Jul 21, 2020
Co-authored-by: Sandy Maguire <[email protected]>
googleson78
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.