Two small fixes #532
Merged
Two small fixes #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change in pkcheck is welcome, but what's the rationale for the return value? |
The allowed values start at 0, so glib complains: GLib-GObject-CRITICAL **: 15:46:56.302: value -1 of type 'gint' is invalid or out of range for property 'pid' of type 'gint'
Error opening `/proc/0/cmdline': Failed to open file ?/proc/0/cmdline?: No such file or directory
|
The property is defined with a min var of 0, so there's a warning printed as the commit id shows: polkit/src/polkit/polkitunixprocess.c Line 413 in c1369cd See for example here where it's passed directly to g_variant_new_uint32: https://github.com/polkit-org/polkit/blob/main/src/polkit/polkitsubject.c#L313 I've fixed that one case, everything else checks |
|
Can we merge this, then? Thanks |
We sure can and we probably will, on today's meeting :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.