Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/infinite looping #38

Merged
merged 4 commits into from
Feb 10, 2024
Merged

Bugfix/infinite looping #38

merged 4 commits into from
Feb 10, 2024

Conversation

pogzyb
Copy link
Owner

@pogzyb pogzyb commented Feb 10, 2024

resolves: #37

This should put a stop to any infinite looping.

This member variable is not used and there are no plans to use it.
It was just accummulating memory for no reason, so it's gone...
@pogzyb pogzyb self-assigned this Feb 10, 2024
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (c9a1492) 70.56% compared to head (f272d91) 69.79%.

Files Patch % Lines
whodap/client.py 44.44% 10 Missing ⚠️
whodap/response.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   70.56%   69.79%   -0.78%     
==========================================
  Files           6        6              
  Lines         632      639       +7     
==========================================
  Hits          446      446              
- Misses        186      193       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pogzyb pogzyb merged commit 6e63e83 into main Feb 10, 2024
30 of 34 checks passed
@pogzyb pogzyb mentioned this pull request Feb 10, 2024
@pogzyb pogzyb deleted the bugfix/infinite-looping branch February 10, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite linking in certain cases
1 participant