yaksa: move yaksa into mpich #7284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
force-pushed
the
2501_yaksa
branch
2 times, most recently
from
a108152 to
3d321a1
Compare
|
test:mpich/ch3/most |
|
test:mpich/ch4/ofi |
raffenet
reviewed
Feb 4, 2025
| @@ -240,9 +240,9 @@ AC_CHECK_ALIGNOF(long double) | |||
|
|
|||
| # backend devices | |||
| supported_backends="seq" | |||
| m4_include([src/backend/cuda/subconfigure.m4]) | |||
There was a problem hiding this comment.
This feature in gen_subcfg_m4 should also work to avoid this issue if a place a sentinel in the top yaksa directory?
# the existence of this file means we should stop recursing down
# the enclosing directory tree
my $stop_sentinel = ".no_subcfg_recursion";There was a problem hiding this comment.
Yaksa manually include those subconfigure files anyway, so I think rename them is cleaner. I am afraid the stop_sentinel mechanism is too subtle and may confuse people sometime.
There was a problem hiding this comment.
I think it's subtle either way that we have to avoid these filenames in the repo. But any more time spent on this aspect is not useful, so let's just ship it.
raffenet
approved these changes
Feb 6, 2025
Move yaksa into mpich repo, potentially to allow less redundancy and less interface overhead. This is a clone from yaksa commit 9e307612e333a133357030d1b2f3dde4d9d43cce. The external yaksa will be kept as is so any application that uses yaksa will continue work. The internal yaksa will diverge this point on.
We need prevent yaksa subconfigure files to be scraped by mpich's gen_subcfg.m4.
The yaksa tests are mostly redundant to mpich's dtpool tests. They assumes yaksa's interface independent of MPI. That will not be maintained after we moved yaksa inside mpich. Thus, we are removing these tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Move yaksa into mpich repo, potentially to allow less redundancy and
less interface overhead.
This is a clone from yaksa commit 9e307612e333a133357030d1b2f3dde4d9d43cce.
The external yaksa will be kept as is so any application that uses yaksa
will continue work. The internal yaksa will diverge this point on.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.