init_shm: shortcut the trivial case of local_size is 1 #7251
+99
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
force-pushed
the
2412_initshm
branch
3 times, most recently
from
d774dd3 to
dbfa948
Compare
hzhou
force-pushed
the
2412_initshm
branch
4 times, most recently
from
672367f to
2cd9487
Compare
|
test:mpich/ch4/ofi |
raffenet
approved these changes
Feb 14, 2025
We are going to shortcut the Init_shm implementation when local_size is 1, and it won't handle Init_shm_get when localsize is 1.
It's simpler to shortcut the trivial case. Set global MPIDU_Init_shm_local_size and MPIDU_Init_shm_local_rank. This prepares the flexibility that later we can extend Init_shm to dynamic processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
It's simpler to shortcut the trivial case.
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.