Change to using sobek instead of goja #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are moving to a fork of goja under grafana org called sobek. More info in: - grafana/k6#3772 - grafana/k6#3773
|
There is a lint error in this MR |
|
@pmalhaire looking over at the lint issues - all of them but one predate my changes and I don't think I will try to remove the "magical numbers" as part of this automatic PR to keep this extension working. The one lint error from these changes is on a line that will have a lint error around magical numbers once the line is split. I will be okay with fixing that one if that is what you want. |
|
I'll fix them too, in a bit of time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving to a fork of goja under grafana org called sobek.
More info in: