feat!: Return actionable errors from Manifest validation #552
+540
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
piotr-roslaniec
force-pushed
the
feat/error-handling#511
branch
4 times, most recently
from
03eccc4 to
43fa48b
Compare
piotr-roslaniec
force-pushed
the
feat/error-handling#511
branch
from
43fa48b to
6fb4745
Compare
piotr-roslaniec
commented
Mar 7, 2025
Comment on lines
+499
to
+509
| let mut expected = vec![ | ||
| "Invalid manifest: Invalid HTTP method", | ||
| "Invalid manifest: Unsupported HTTP status", | ||
| "Invalid manifest: Token `<% MISSING_TOKEN %>` not declared in `vars`", | ||
| "Manifest HTTP error: HTTP header mismatch: expected Bearer <% MISSING_TOKEN %>, actual Bearer invalid-token", | ||
| "Manifest HTTP error: HTTP header mismatch: expected invalid/type, actual application/json", | ||
| "Template error: Variable missing for key: UNUSED_TOKEN", | ||
| "Manifest HTTP error: HTTP method mismatch: expected POST, actual INVALID_METHOD", | ||
| "Manifest HTTP error: HTTP URL mismatch: expected https://api.example.com, actual ftp://invalid-scheme.com", | ||
| "Extraction failed: No data to match against" | ||
| ]; |
There was a problem hiding this comment.
This is the kind of feedback the end-user can expect to receive from the notary.
cc: @drewjenkins
piotr-roslaniec
force-pushed
the
feat/error-handling#511
branch
from
6fb4745 to
d50f079
Compare
piotr-roslaniec
requested review from
mattes,
devloper,
drewjenkins,
Autoparallel,
0xFloyd,
lonerapier and
0xJepsen
mattes
approved these changes
Mar 7, 2025
|
The failing tests can be ignored, because they don't exist in main anymore. |
|
@piotr-roslaniec #556 may be worth considering alongside this PR and with the rebase that will happen. What do you think? |
|
@Autoparallel I can address this in the next PR |
|
@piotr-roslaniec sounds good, sir! |
piotr-roslaniec
force-pushed
the
feat/error-handling#511
branch
from
57741d9 to
e6399b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #547 - Please review it first
Related Issues
Changes
ManifestValidationResultto aggregate validation errors and extracted valuesRequired Reviews
Minimum number of reviews before merge: 2