remove redundant variables in manifest #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-roslaniec
approved these changes
Mar 4, 2025
|
CI is not running 🤔 |
lonerapier
force-pushed
the
chore/manifest-redundant-variables
branch
from
d297766 to
9515bff
Compare
|
working now!! |
|
Good catch! |
lonerapier
force-pushed
the
chore/manifest-redundant-variables
branch
from
9515bff to
fff5c66
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Summary
Removes redundant variables from manifest, and reuses manifest request.
Required Reviews
Minimum number of reviews before merge: 1
TODO
Didn't remove
target_body, it's not used anywhere in web prover, but is used client side