forked from ivanseidel/DueTimer
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding support to use the TC Block as a hardware counter
- Loading branch information
Showing
2 changed files
with
92 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b6034b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't change the Main
DueTimer
class. Instead, creating aTimerCounter
class that extendsDueTimer
is the best solution, to avoid a class with thousands of methods. But, it's good to add the pin and Channel to theTimers configuration array
.What I suggest:
TimerCounter
that extendsDueTimer
getValue
,setValue
.start
method to runsetUpCounter
protected
method and do others modifications to work properlyb6034b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comment! Let's move this discussion to the pull request I created as I rebased my branch
counter-implementation
on your currentmaster
branch (and thus making this commit disappear).