Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add meeting link option #207

Merged
merged 3 commits into from
Jan 11, 2025
Merged

Conversation

bjohansebas
Copy link
Contributor

@bjohansebas bjohansebas commented Nov 21, 2024

To avoid repeating a template due to a link change, the option to add a link is included, reducing template duplication with a simple link

ref: expressjs/discussions#283

@bjohansebas
Copy link
Contributor Author

I'll see if I can manage to pass the data option suggested in #206.

@bjohansebas bjohansebas marked this pull request as draft November 21, 2024 23:13
@jonchurch
Copy link
Member

This is actually a lot simpler for now though and is worth considering

it's reasonable to think someone would provide meeting link as a baseline for a meeting action

Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

action.yml Outdated Show resolved Hide resolved
@bjohansebas bjohansebas marked this pull request as ready for review November 22, 2024 01:25
Co-authored-by: Jon Church <[email protected]>
Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets update the default meeting template to use meetingLink if it is available

The notes default doesn't have a meeting link section, so no need there

https://github.com/pkgjs/meet/blob/main/lib/default-template.js#L42

Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to request changes on the default template comment

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I am a fan of simple defaults for this kind of stuff for sure.

@wesleytodd wesleytodd merged commit 5abf3a5 into pkgjs:main Jan 11, 2025
@bjohansebas bjohansebas deleted the link-option branch January 11, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants