Skip to content

Commit

Permalink
MC-19366: Fixes order of rules and silences GraphQL field name valida…
Browse files Browse the repository at this point in the history
…tion
  • Loading branch information
jean-bernard-valentaten committed Sep 17, 2019
1 parent 43ef0a4 commit c539ed4
Showing 1 changed file with 24 additions and 25 deletions.
49 changes: 24 additions & 25 deletions Magento2/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,30 @@
<severity>6</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.GraphQL.ValidArgumentName">
<severity>6</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.GraphQL.ValidEnumValue">
<severity>6</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.GraphQL.ValidFieldName">
<!--
* Field name validation deactivated as per request
* https://github.com/magento/magento-coding-standard/pull/141#discussion_r323349939
-->
<severity>0</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.GraphQL.ValidTopLevelFieldName">
<severity>6</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.GraphQL.ValidTypeName">
<severity>6</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.Whitespace.MultipleEmptyLines">
<severity>6</severity>
<type>warning</type>
Expand Down Expand Up @@ -522,31 +546,6 @@
<rule ref="Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines">
<severity>0</severity>
</rule>
<rule ref="Magento2.GraphQL.ValidTypeName">
<severity>6</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.GraphQL.ValidFieldName">
<!--
* Field name validation deactivated as per request
* https://github.com/magento/magento-coding-standard/pull/141#discussion_r323349939
-->
<exclude name="Magento2.GraphQL.ValidFieldName" />
<severity>6</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.GraphQL.ValidArgumentName">
<severity>6</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.GraphQL.ValidTopLevelFieldName">
<severity>6</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.GraphQL.ValidEnumValue">
<severity>6</severity>
<type>warning</type>
</rule>

<!-- Severity 5 warnings: PHPDoc formatting and commenting issues. -->
<rule ref="Magento2.Commenting.ClassAndInterfacePHPDocFormatting">
Expand Down

0 comments on commit c539ed4

Please sign in to comment.