fix go vet errors in tests

pivotal-cf · Aug 31, 2018 · 93c6d69 · 93c6d69
1 parent f17f7bf
commit 93c6d69
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 11 deletions.
diff --git a/acceptance/export_installation_test.go b/acceptance/export_installation_test.go
@@ -74,7 +74,7 @@ var _ = Describe("export-installation command", func() {
 		Eventually(session, 5).Should(gexec.Exit(0))
 		Expect(session.Err).To(gbytes.Say("exporting installation"))
 		Expect(session.Err).To(gbytes.Say("waiting for response"))
-		Expect(session.Err).To(gbytes.Say(`100(\.\d+)?%`))
+		Expect(session.Err).To(gbytes.Say(`100(\.\d+)?`))
 		Expect(session.Err).To(gbytes.Say("finished exporting installation"))
 
 		content, err := ioutil.ReadFile(outputFileName)

diff --git a/acceptance/tile_metadata_test.go b/acceptance/tile_metadata_test.go
@@ -15,11 +15,12 @@ import (
 var _ = Describe("tile-metadata command", func() {
 	var (
 		productFile *os.File
-		err         error
 	)
 
 	BeforeEach(func() {
+		var err error
 		productFile, err = ioutil.TempFile("", "fake-tile")
+		Expect(err).NotTo(HaveOccurred())
 		z := zip.NewWriter(productFile)
 
 		f, err := z.Create("metadata/fake-tile.yml")

diff --git a/acceptance/unstage_product_test.go b/acceptance/unstage_product_test.go
@@ -17,7 +17,6 @@ import (
 
 var _ = Describe("unstage-product command", func() {
 	var (
-		stageRequest       string
 		stageRequestMethod string
 		server             *httptest.Server
 	)
@@ -60,9 +59,8 @@ var _ = Describe("unstage-product command", func() {
 					}
 					responseString = `{}`
 					stageRequestMethod = req.Method
-					reqBody, err := ioutil.ReadAll(req.Body)
+					_, err := ioutil.ReadAll(req.Body)
 					Expect(err).NotTo(HaveOccurred())
-					stageRequest = string(reqBody)
 				default:
 					out, err := httputil.DumpRequest(req, true)
 					Expect(err).NotTo(HaveOccurred())
@@ -115,9 +113,8 @@ var _ = Describe("unstage-product command", func() {
 					}
 					responseString = `[]`
 					stageRequestMethod = req.Method
-					reqBody, err := ioutil.ReadAll(req.Body)
+					_, err := ioutil.ReadAll(req.Body)
 					Expect(err).NotTo(HaveOccurred())
-					stageRequest = string(reqBody)
 				default:
 					out, err := httputil.DumpRequest(req, true)
 					Expect(err).NotTo(HaveOccurred())

diff --git a/api/installation_asset_service_test.go b/api/installation_asset_service_test.go
@@ -37,16 +37,12 @@ var _ = Describe("InstallationAssetService", func() {
 	Describe("DownloadInstallationAssetCollection", func() {
 		var (
 			outputFile *os.File
-			bar        *fakes.Progress
-			liveWriter *fakes.LiveWriter
 		)
 
 		BeforeEach(func() {
 			var err error
-			liveWriter = &fakes.LiveWriter{}
 			outputFile, err = ioutil.TempFile("", "")
 			Expect(err).NotTo(HaveOccurred())
-			bar = &fakes.Progress{}
 		})
 
 		AfterEach(func() {