Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

*: remove deprecated io/ioutil #1292

Merged
merged 3 commits into from
Jul 2, 2021
Merged

*: remove deprecated io/ioutil #1292

merged 3 commits into from
Jul 2, 2021

Conversation

sleepymole
Copy link
Contributor

What problem does this PR solve?

Since we have upgraded to go 1.16 in #1159, I think we can remove the Deprecation of io/ioutil.

What is changed and how it works?

Remove all deprecated io/ioutil usages except pkg/lightning/web/res_vfsdata.go, because it was generated by vfsgen.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

Release note

No release note

@ti-chi-bot ti-chi-bot requested review from glorv and kennytm June 28, 2021 05:08
@sleepymole sleepymole requested review from overvenus and 3pointer June 28, 2021 05:09
@kennytm
Copy link
Collaborator

kennytm commented Jun 28, 2021

maybe we can get rid of vfsgen in the future 😃 shurcooL/vfsgen#91

kennytm
kennytm reviewed Jun 28, 2021
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/lightning/mydump/reader_test.go Outdated Show resolved Hide resolved
pkg/storage/gcs_test.go Outdated Show resolved Hide resolved
pkg/storage/gcs_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jun 28, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jul 2, 2021
@sleepymole
Copy link
Contributor Author

@overvenus Can you help merge this pr? Thanks

@kennytm
Copy link
Collaborator

kennytm commented Jul 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 82c2198

@ti-chi-bot ti-chi-bot merged commit 55bb750 into pingcap:master Jul 2, 2021
@sleepymole sleepymole deleted the ioutil branch July 2, 2021 07:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm approved these changes

@overvenus overvenus overvenus approved these changes

@glorv glorv Awaiting requested review from glorv

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
size/L status/can-merge status/LGT2 LGTM2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sleepymole @kennytm @ti-chi-bot @overvenus