save port and paylaod_signature to files #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbruski
reviewed
Feb 1, 2021
|
Been running with this (manually) merged for nearly a year now. Provides a critical piece of functionality. Would really like to see it merged! |
Thank you for the confirmation. I think the idea is good and we should merge. However we could improve the structure a bit:
Please confirm this is acceptable. If yes, we can modify the merge request with the new data, test again and merge. |
|
This sounds good to me!
…On Fri, Jan 21, 2022 at 8:46 AM goonix ***@***.***> wrote:
Been running with this (manually) merged for nearly a year now. Provides a
critical piece of functionality. Would really like to see it merged!
Thank you for the confirmation. I think the idea is good and we should
merge. However we could improve the structure a bit:
- structure everything under the same *directory*:
/opt/piavpn-manual/port_forwarding
- name files as follows:
- /opt/piavpn-manual/port_forwarding/payload_and_signature
- /opt/piavpn-manual/port_forwarding/port
- /opt/piavpn-manual/port_forwarding/expires_at
Please confirm this is acceptable. If yes, we can modify the merge request
with the new data, test again and merge.
—
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABW26P67K5W2BJ3RIVCGADDUXFPSFANCNFSM4W24JTXA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
any news on this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose is like for saving token in a file :
by saving payload and signature and port
we can use these values outside of these scripts
Need that at least for port because the only way to get the port is to read terminal,
not easily usable in a lot of way
and store port and payload_signature in files do not broke actual usage I think
Thanx !