Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #447

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Update README.md #447

merged 2 commits into from
Apr 24, 2019

Conversation

diginc
Copy link
Collaborator

@diginc diginc commented Apr 24, 2019

Clarify that people running --net=host should set ServerIP for Pi-hole to function correctly.

I'll have to try to add some automation around this later to try to warn only the network host mode users if they miss it.

See : #432 #443

diginc added 2 commits April 24, 2019 13:37
Clarify that people running --net=host should set ServerIP for Pi-hole to function correctly.

I'll have to try to add some automation around this later to try to warn only the network host mode users if they miss it.
@diginc diginc merged commit cf36276 into master Apr 24, 2019
@diginc diginc deleted the ServerIP-net-host branch April 24, 2019 19:02
@itcotta
Copy link

itcotta commented Aug 31, 2019

It should perhaps be also worth noting that the net-host only works in linux hosts.
Windows running docker doesn't support it according to: https://docs.docker.com/network/host/

The host networking driver only works on Linux hosts, and is not supported on Docker Desktop for Mac, Docker Desktop for Windows, or Docker EE for Windows Server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants