Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a toggle to allow shape files with no dbf #41

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

JoolsMcFly
Copy link
Contributor

Hi.

This PR fixes #36 as it gives users the ability to process a shape file with no matching dbf file.
A call to $shp->setAllowNoDbf(true); does the trick.

I left open the PR targeting master because 3.1.x and master branches are different enough (no psalm, use of ShapeFile enum etc) to have me change code from my first PR to make it work in 3.1.x.

Thanks for reviewing.

@JoolsMcFly JoolsMcFly marked this pull request as draft November 19, 2024 21:47
@JoolsMcFly JoolsMcFly force-pushed the feature/36-allow-no-dbf branch from fa57fb1 to 09610f5 Compare November 19, 2024 22:00
@JoolsMcFly JoolsMcFly marked this pull request as ready for review November 19, 2024 22:04
Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@MauricioFauth MauricioFauth self-assigned this Dec 8, 2024
@MauricioFauth MauricioFauth added this to the 3.1.0 milestone Dec 8, 2024
@MauricioFauth MauricioFauth merged commit a21b619 into phpmyadmin:3.1.x Dec 8, 2024
19 checks passed
MauricioFauth added a commit that referenced this pull request Dec 8, 2024
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@JoolsMcFly JoolsMcFly deleted the feature/36-allow-no-dbf branch December 9, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants