Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release phpdocumentor/reflection-docblock lock #178

Merged

Conversation

IanDelMar
Copy link
Contributor

The phpdocumentor/reflection-docblock was locked to version 5.3.0 in #165 because version 5.4.0 caused many PHPStan tags to disappear. This was reported in issue #365 and fixed in version 5.4.1.

@IanDelMar
Copy link
Contributor Author

It seems PHPStan is now more strict about distinguishing between \phpDocumentor\Reflection\DocBlockFactory and \phpDocumentor\Reflection\DocBlockFactoryInterface. \phpDocumentor\Reflection\DocBlockFactory::createInstance() returns an instance of DocBlockFactory that implements DocBlockFactoryInterface, and the return type is declared to be DocBlockFactoryInterface. In previous versions of PHPStan, using \phpDocumentor\Reflection\DocBlockFactory as the type for $docBlockFactory did not cause any errors.

@szepeviktor
Copy link
Member

Doesn't it produce some difference in stubs?

@IanDelMar
Copy link
Contributor Author

IanDelMar commented May 21, 2024

No, that has been fixed.

image

@szepeviktor
Copy link
Member

Thank you.

@szepeviktor szepeviktor merged commit a5558fc into php-stubs:master May 21, 2024
2 checks passed
@IanDelMar IanDelMar deleted the release-reflection-docblock-lock branch May 29, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants