Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise PHPStan level to 9 #175

Merged
merged 4 commits into from
May 9, 2024
Merged

Raise PHPStan level to 9 #175

merged 4 commits into from
May 9, 2024

Conversation

IanDelMar
Copy link
Contributor

  • (Not related to level 9) Requires functionMap.php in the constructor. We hardly gain anything by doing this in getAdditionalTagsFromMap(). Adds a doc comment to inform PHPStan of the type change after array_shift().
  • Renames $name to $fullSymbolName to indicate what name the variable holds throughout the method. Adds a doc comment to $fullSymbolName to let PHPStan know about its type.
  • Replaces a check for the existence of the stmts property with checks for ClassLike and Namespace_ entities. This helps PHPStan understand what to expect from $node->stmts. Only ClassLike and Namespace_ need their children to be traversed.

@szepeviktor
Copy link
Member

Thank you.

@szepeviktor szepeviktor merged commit 6e1ef76 into php-stubs:master May 9, 2024
2 checks passed
@IanDelMar IanDelMar deleted the level9 branch August 25, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants