Fix issue #14

Fixed issue 14. The problem was actually not successfully prevented in the Hitter class and I also fixed it there.
philosofool · Jun 9, 2020 · 9226612 · 9226612
1 parent 6337e41
commit 9226612
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 33 deletions.
diff --git a/BaseClasses/player/Hitter.py b/BaseClasses/player/Hitter.py
@@ -279,23 +279,26 @@ def adjToPA(self,PA):
             To approximate zero, pass a small float (.01) as PA.
         """
         try:
-            self.formerPA = self.PA
-            ratio = PA/self.PA
-            self.PA = self.PA * ratio
-            self.AB = self.AB * ratio
-            self.BB = self.BB * ratio
-            self.H1B = self.H1B  * ratio
-            self.H2B = self.H2B  * ratio
-            self.H3B = self.H3B  * ratio
-            self.HR = self.HR  * ratio
-            self.R = self.R  * ratio
-            self.RBI = self.RBI  * ratio
-            self.SB = self.SB  * ratio
-            self.CS = self.CS  * ratio
-            self.SO = self.SO  * ratio
-            self.hits = self.calcHits()
+            if PA == 0:
+                pass
+            else:
+                self.formerPA = self.PA
+                ratio = PA/self.PA
+                self.PA = self.PA * ratio
+                self.AB = self.AB * ratio
+                self.BB = self.BB * ratio
+                self.H1B = self.H1B  * ratio
+                self.H2B = self.H2B  * ratio
+                self.H3B = self.H3B  * ratio
+                self.HR = self.HR  * ratio
+                self.R = self.R  * ratio
+                self.RBI = self.RBI  * ratio
+                self.SB = self.SB  * ratio
+                self.CS = self.CS  * ratio
+                self.SO = self.SO  * ratio
+                self.hits = self.calcHits()
         except ZeroDivisionError:
-            pass
+            print("Hitter {} has 0 PA. Cannot adjust plate appearances.".format(self))
 
     def asNumberPA(self,pa):
         """

diff --git a/BaseClasses/player/Pitcher.py b/BaseClasses/player/Pitcher.py
@@ -90,24 +90,38 @@ def xWHIP(self):
         return (self.lgWHIP - self.WHIP())*self.IP
 
     def adjToIP(self,IP):
-        self.formerIP = self.IP
+        """
+        Normalizes all the players counting stats to a new number of IP.
+
+        Parameters
+        ----------
+        IP : numeric
+            The number of IP the player is adjusted to. 
+            In order to prevent data loss, zero is not allowed and passing zero will have no effect.
+            To approximate zero, pass a small float (.01) as PA.
+
+            If the player's IP are already Zero, this has no effect
+        """
+
         try:
-            ratio = IP/self.IP
-        except:
-            print(self.name+" Has 0 IP. in Pitcher.adjToIP"
-                  )
-            ratio = 0
-        self.W = self.W * ratio
-        self.L = self.L * ratio
-        self.GS = self.GS * ratio
-        self.G = self.G  * ratio
-        self.SV = self.SV  * ratio
-        self.IP = self.IP  * ratio
-        self.H = self.H * ratio
-        self.ER = self.ER * ratio
-        self.HR = self.HR * ratio
-        self.SO = self.SO * ratio
-        self.BB = self.BB * ratio
+            if IP == 0:
+                pass
+            else:
+                self.formerIP = self.IP
+                ratio = IP/self.IP        
+                self.W = self.W * ratio
+                self.L = self.L * ratio
+                self.GS = self.GS * ratio
+                self.G = self.G  * ratio
+                self.SV = self.SV  * ratio
+                self.IP = self.IP  * ratio
+                self.H = self.H * ratio
+                self.ER = self.ER * ratio
+                self.HR = self.HR * ratio
+                self.SO = self.SO * ratio
+                self.BB = self.BB * ratio
+        except ZeroDivisionError:
+            print("Pitcher {} has 0 IP. Cannot adjust stats to innings pitched.".format(self))
 
     def asNumberIP(self,ip):
         guy = deepcopy(self)