Fix typos in code for embedded_graphics crate in chapter 3
#1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still won't compile on account of the fact that the `Point` type apparently doesn't implement `Into<(usize, usize)>`. Attempting to change the type just results in more issues
proudmuslim-dev
commented
Jan 27, 2024
| // ignore any pixels that are out of bounds. | ||
| let (width, height) = { | ||
| let info = self.framebuffer.info(); | ||
| (info.width, info.height) | ||
| } | ||
|
|
||
| if let Ok((x @ 0..width, y @ 0..height)) = coordinates.try_into() { |
There was a problem hiding this comment.
This still won't compile on account of the fact that the Point type apparently doesn't implement Into<(usize, usize)>. Attempting to change the type just results in more issues because the range values must be of the same integer type and have to be constants. The checks could of course be moved down but that would look much worse
There was a problem hiding this comment.
I should also note that this syntax requires you to enable the experimental exclusive_range_pattern feature in order for it to be valid in the first place
There was a problem hiding this comment.
Thanks! This is already a good improvement, so let's merge this. I try my best to continue working on finishing the post soon.
phil-opp
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.