fix(richtext-lexical): combine 2 normalizeMarkdown implementations and fix code block regex #10470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanJablo
commented
Jan 9, 2025
| @@ -82,7 +82,7 @@ function $convertFromMarkdownString( | |||
| transformers: Array<Transformer> = TRANSFORMERS, | |||
| node?: ElementNode, | |||
| shouldPreserveNewLines = false, | |||
| shouldMergeAdjacentLines = false, | |||
| shouldMergeAdjacentLines = true, | |||
There was a problem hiding this comment.
This classifies as a bug fix rather than a breaking change. It is standard behavior and what most people will expect.
|
I found another issue with new lines/ This line break is showing |
|
🚀 This is included in version v3.17.0 |
|
It seems to have been fixed. Thanks for reporting @bratvanov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix it #10387
I don't know why we had 2 different copies of normalizeMarkdown.
Also, the most up-to-date one still had a bug where lines were considered as if they were inside codeblocks when they weren't.
How I tested that it works:
normalizeMarkdownimplementation from this PR into the website repo, and made sure it is called before the conversion to editorState.An extra pair of eyes would be nice to make sure I'm not getting confused with the imports.