fix(richtext-lexical): remove alteration of lexical text format constant #10415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #9507, which aims to enable only used formats to be enabled in lexical, the
TEXT_TYPE_TO_FORMATconstant in the lexical library was altered. This means it becomes impossible to create a feature relying on thehighlightformat. I am of the opinion that this should not be the case; and have used this for a lexical feature in one of my projects. The type ofenabledFormatsof thecreateClientFeaturefunction should also be updated to reflect the availability of the format.This PR aims to:
enabledFormats