Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for send v2 module #554

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benalleng
Copy link
Contributor

@benalleng benalleng commented Feb 25, 2025

This is an attempt to both add some additional test vectors and to create some headway on the tests deficiencies caught by cargo mutants ahead of time.
Currently missing is the test for process_response which I was unable to make significant progress on as I was not able to parse what I anticipated as expected values for the ohttp encapsulation/decapsulation. Ideally we should have a test for that added so I have created a TODO there.

I have tried my best to keep the tests in accordance with the design laid out in #487

This is an attempt to both add some additional test vectors and to create some
headway on the tests deficiencies caught by cargo mutants.
Currently missing is the test for process_response which I was unable to make
significant progress on as I was not able to parse what I anticipated as
expected values for the ohttp encapsulation/decapsulation.
Ideally we should have a test for that added so I have created a TODO there.
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13528487824

Details

  • 54 of 54 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 79.463%

Files with Coverage Reduction New Missed Lines %
payjoin/src/send/mod.rs 2 93.91%
Totals Coverage Status
Change from base Build 13524514317: 0.2%
Covered Lines: 4206
Relevant Lines: 5293

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants