Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't accept invalid certs even in tests #550

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

nothingmuch
Copy link
Collaborator

This is a minor cleanup change from the WIP self signed certificates that can be merged independently.

Turns out we're actually not (no longer?) relying on invalid certificates because the with_cert functionality just asserts that the self signed certificate, which is its own root, is valid.

@coveralls
Copy link
Collaborator

coveralls commented Feb 21, 2025

Pull Request Test Coverage Report for Build 13466665336

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 79.045%

Totals Coverage Status
Change from base Build 13466524337: -0.008%
Covered Lines: 4040
Relevant Lines: 5111

💛 - Coveralls

@nothingmuch nothingmuch force-pushed the no-accept-invalid-certs branch from 81fec37 to edb595e Compare February 21, 2025 23:00
Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK edb595e

This is a more restrictive change, so since tests pass it looks good to me.

@DanGould DanGould merged commit 0db0af3 into payjoin:master Feb 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants