FISH-10055 Introduce Payara Micro Global Context Root Support #7187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lprimak
reviewed
Feb 12, 2025
| @@ -239,4 +249,18 @@ void runJSPC(final DeploymentContext dc) throws DeploymentException { | |||
| throw de; | |||
| } | |||
| } | |||
|
|
|||
| private String getProperty(String value) { | |||
There was a problem hiding this comment.
Should this use TranslateConfigView?
lprimak
reviewed
Feb 12, 2025
| @@ -136,6 +136,16 @@ public <V> V loadMetaData(Class<V> type, DeploymentContext dc) { | |||
| if (contextRoot == null) | |||
| contextRoot = ((GenericHandler)dc.getArchiveHandler()).getDefaultApplicationNameFromArchiveName(dc.getOriginalSource()); | |||
|
|
|||
|
|
|||
| if (this.env.getRuntimeType().isMicro()) { | |||
There was a problem hiding this comment.
FYI: I see this kind of code more and more sprinkled throughout the codebase.
This is a code smell. There should be a strategy pattern utilized here to get more cohesion / convergence of code that belongs in Micro / Server / DAS / instance
|
Why are we defining this via system or environment property? Shouldn't this just be a Payara Micro boot option? |
|
Reading via environment variable seems a logical configuration mechanism, but system property I'm less sure about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A user can specify the
payaramicro.globalContextRootproperty to specify the global context root for any application deployed.e.g.
payaramicro.globalContextRoot = portalapplication1 context root =
app1application2 context root =
app2Results in
/portal/app1and/portal/app2Important Info
Blockers
n/a
Testing
New tests
n/a
Testing Performed
Testing performed in separate issue
Testing Environment
Documentation
pending
Notes for Reviewers