-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stateful Controls #559
base: dev
Are you sure you want to change the base?
Stateful Controls #559
Conversation
I can see this is a draft, LMK when you want a review! Happy to take a look on specific points if you want direct feedback earlier. (Although FWIW I think it'd be cleanest if #484 is the next 'big' thing we merge, just to avoid us having too many 'big' things in flight at the same time.) |
I'm good with that, although I think that's in @andyElking's control ;) |
One question you could answer @patrick-kidger . Background: With this PR, the BacksolveAdjoint doesn't work with the new UBP (which is not new, it didn't before either). However, with these changes, it seems to me you it could work with static step size solvers (since you can just take the reverse of the brownian path). For adaptive solvers that reject steps, that already doesn't work for UBP, and for pre visible adaptive solvers maybe that works on the back solve (but if it takes different steps, I'm not sure it would work). My question ii, is it worth adding support for UBP with back solve adjoint (it would require some more book keeping to have the path know more about whether its being run forward/reverse, which it's basically agnostic to currently, so that it could provide the same path, but I think it would be implementable), or does this not matter as a new feature (since I have generally perceived your opinion of backsolveadjoint as detailed below)? |
This is the v1 of the stateful control PR.
This PR introduces a suite of internally breaking changes which allow for stateful paths. To the non-advanced user, this will likely have no impact on the way they interact with diffrax. It should not impact ODE users at all. SDEs users may be impacted as they might want to try the new "UnsafeBrownianPath" (or as I am calling it "DirectBrownianPath" since it isn't really that unsafe any more), but this should just allow for faster code. I tried several approaches to this problem, but I think based on the conversations in other issues (e.g. #548), that this is at least someone an aligned vision.
Functionaly, this was just a lot of adding arguments to things to support an extra path_state variable. Hence the internal breaking changes. However, these breaking changes come with some decent motivation:
Currently, this PR is missing a few things though.