-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vaultwarden): added support for changing the controller update strategy #613
Conversation
WalkthroughWalkthroughThe recent update to the Vaultwarden Helm chart includes a version increment from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
charts/vaultwarden/README.md (2)
5-5
: Fix spaces inside link text and loose punctuation marks.There are unnecessary spaces inside the link text and a loose punctuation mark.
- [ ](https://charts.pascaliske.dev/charts/vaultwarden/)[ ](https://charts.pascaliske.dev/charts/vaultwarden/)[ ](https://charts.pascaliske.dev/charts/vaultwarden/) + [](https://charts.pascaliske.dev/charts/vaultwarden/)[](https://charts.pascaliske.dev/charts/vaultwarden/)[](https://charts.pascaliske.dev/charts/vaultwarden/)Tools
LanguageTool
[uncategorized] ~5-~5: Loose punctuation mark.
Context: ...cation-informational?style=flat-square) ](https://charts.pascaliske.dev/charts/va...(UNLIKELY_OPENING_PUNCTUATION)
Markdownlint
5-5: null
Spaces inside link text(MD039, no-space-in-links)
5-5: null
Spaces inside link text(MD039, no-space-in-links)
5-5: null
Spaces inside link text(MD039, no-space-in-links)
56-56
: Add a comma after "Currently".A comma is needed after the word "Currently" to improve readability.
- | controller.updateStrategy | object | `{}` | The controller update strategy. Currently only applies to controllers of kind `Deployment`. | + | controller.updateStrategy | object | `{}` | The controller update strategy. Currently, only applies to controllers of kind `Deployment`. |Tools
LanguageTool
[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Currently’.
Context: ...{}
| The controller update strategy. Currently only applies to controllers of kind `De...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
charts/vaultwarden/Chart.yaml
is excluded by!**/*.yaml
charts/vaultwarden/templates/controller.yaml
is excluded by!**/*.yaml
charts/vaultwarden/values.yaml
is excluded by!**/*.yaml
Files selected for processing (1)
- charts/vaultwarden/README.md (2 hunks)
Additional context used
LanguageTool
charts/vaultwarden/README.md
[uncategorized] ~5-~5: Loose punctuation mark.
Context: ...cation-informational?style=flat-square) ](https://charts.pascaliske.dev/charts/va...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Currently’.
Context: ...{}
| The controller update strategy. Currently only applies to controllers of kind `De...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Markdownlint
charts/vaultwarden/README.md
5-5: null
Spaces inside link text(MD039, no-space-in-links)
5-5: null
Spaces inside link text(MD039, no-space-in-links)
5-5: null
Spaces inside link text(MD039, no-space-in-links)
No description provided.