Skip to content

Commit

Permalink
Fix new draft-release release flow: avoid duplicates, capture changel…
Browse files Browse the repository at this point in the history
…og (#439)

As observed in
#432 (comment),
after #432, release CI has two problems:

- It creates two releases, one as a draft that the artifacts are
uploaded too, and then one that's published. I'm guessing this is
because the `name` key wasn't set on the draft uploads
- The release notes couldn't be created, because the repo and its code
(particularly `CHANGES.md`) wasn't available in the publishing step
  • Loading branch information
huonw authored Dec 10, 2024
1 parent e9f52bd commit 62894d0
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ needs.determine-tag.outputs.release-tag }}
name: scie-pants ${{ needs.determine-tag.outputs.release-version }}
draft: true
# placeholder body to help someone track down why a release is still in draft:
body: "Release job in progress: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
Expand All @@ -116,6 +117,11 @@ jobs:
runs-on: ubuntu-22.04
steps:
# Now, do the human-facing prep on the release (changelog etc.), and publish it
- name: Checkout scie-pants ${{ needs.determine-tag.outputs.release-tag }}
uses: actions/checkout@v4
with:
ref: ${{ needs.determine-tag.outputs.release-tag }}

- name: Prepare Changelog
id: prepare-changelog
uses: a-scie/actions/[email protected]
Expand Down

0 comments on commit 62894d0

Please sign in to comment.