Skip to content

Commit

Permalink
Merge pull request #178 from pantheon-systems/177-remove-unused-place…
Browse files Browse the repository at this point in the history 
…holder

Remove unused `placeholder` value that's causing PHP notices
  • Loading branch information
@danielbachhuber
danielbachhuber authored Feb 3, 2020
2 parents 2a59815 + 35394c3 commit 7696ff8
Show file tree
Hide file tree
Showing 5 changed files with 94 additions and 89 deletions.
5 changes: 4 additions & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
**Tags:** authentication, SAML
**Requires at least:** 4.4
**Tested up to:** 5.3
**Stable tag:** 0.8.2
**Stable tag:** 0.8.3
**License:** GPLv2 or later
**License URI:** http://www.gnu.org/licenses/gpl-2.0.html

Expand Down Expand Up @@ -277,6 +277,9 @@ There is no third step. Because SimpleSAMLphp loads WordPress, which has WP Nati

## Changelog ##

### 0.8.3 (February 3, 2020) ###
* Removes unused `placeholder` value that's causing PHP notices [[#178](https://github.com/pantheon-systems/wp-saml-auth/pull/178)].

### 0.8.2 (January 22, 2020) ###
* Fixes method declaration for methods used statically [[#176](https://github.com/pantheon-systems/wp-saml-auth/pull/176)].

Expand Down
3 changes: 1 addition & 2 deletions inc/class-wp-saml-auth-settings.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,8 @@ public static function field_callback( $arguments ) {
case 'text':
case 'url':
printf(
'<input name="%1$s" type="text" id="%1$s" placeholder="%2$s" value="%3$s" class="regular-text" />',
'<input name="%1$s" type="text" id="%1$s" value="%2$s" class="regular-text" />',
esc_attr( $uid ),
esc_attr( $arguments['placeholder'] ),
esc_attr( $value )
);
break;
Expand Down
168 changes: 84 additions & 84 deletions languages/wp-saml-auth.pot
View file
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
# Copyright (C) 2019 Pantheon
# Copyright (C) 2020 Pantheon
# This file is distributed under the same license as the WP SAML Auth plugin.
msgid ""
msgstr ""
"Project-Id-Version: WP SAML Auth 0.7.3\n"
"Project-Id-Version: WP SAML Auth 0.8.3\n"
"Report-Msgid-Bugs-To: https://wordpress.org/support/plugin/wp-saml-auth\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <[email protected]>\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"POT-Creation-Date: 2019-11-07T18:18:22+00:00\n"
"POT-Creation-Date: 2020-02-03T23:02:50+00:00\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"X-Generator: WP-CLI 2.2.0\n"
"X-Generator: WP-CLI 2.4.0\n"
"X-Domain: wp-saml-auth\n"

#. Plugin Name of the plugin
Expand All @@ -35,193 +35,193 @@ msgstr ""
msgid "https://pantheon.io"
msgstr ""

#. Translators: Links to the WP SAML Auth plugin.
#: inc/class-wp-saml-auth.php:83
msgid "WP SAML Auth wasn't able to find the <code>OneLogin\\Saml2\\Auth</code> class. Please verify your Composer autoloader, or <a href='%s'>visit the plugin page</a> for more information."
msgstr ""

#. Translators: Links to the WP SAML Auth plugin.
#: inc/class-wp-saml-auth.php:109
msgid "WP SAML Auth wasn't able to find the <code>%1$s</code> class. Please check the <code>simplesamlphp_autoload</code> configuration option, or <a href='%2$s'>visit the plugin page</a> for more information."
msgstr ""

#: inc/class-wp-saml-auth.php:158
msgid "Use one-click authentication:"
msgstr ""

#: inc/class-wp-saml-auth.php:159
msgid "Sign In"
msgstr ""

#: inc/class-wp-saml-auth.php:160
msgid "Or, sign in with WordPress:"
msgstr ""

#. Translators: Includes error reason from OneLogin.
#: inc/class-wp-saml-auth.php:244
msgid "User is not authenticated with SAML IdP. Reason: %s"
msgstr ""

#: inc/class-wp-saml-auth.php:290
msgid "Invalid provider specified for SAML authentication"
msgstr ""

#: inc/class-wp-saml-auth.php:315
msgid "No attributes were present in SAML response. Attributes are used to create and fetch users. Please contact your administrator"
msgstr ""

#. Translators: Communicates how the user is fetched based on the SAML response.
#: inc/class-wp-saml-auth.php:322
msgid "\"%1$s\" attribute is expected, but missing, in SAML response. Attribute is used to fetch existing user by \"%2$s\". Please contact your administrator."
msgstr ""

#: inc/class-wp-saml-auth.php:337
msgid "No WordPress user exists for your account. Please contact your administrator."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:94
#: inc/class-wp-saml-auth-settings.php:146
#: inc/class-wp-saml-auth-settings.php:145
msgid "WP SAML Auth Settings"
msgstr ""

#. translators: Link to the plugin settings page.
#: inc/class-wp-saml-auth-settings.php:151
#: inc/class-wp-saml-auth-settings.php:150
msgid "Settings are defined with a filter and unavailable for editing through the backend. <a href=\"%s\">Visit the plugin page</a> for more information."
msgstr ""

#. translators: Link to the plugin settings page.
#: inc/class-wp-saml-auth-settings.php:158
#: inc/class-wp-saml-auth-settings.php:157
msgid "Use the following settings to configure WP SAML Auth with the 'internal' connection type. <a href=\"%s\">Visit the plugin page</a> for more information."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:162
#: inc/class-wp-saml-auth-settings.php:161
msgid "Settings are actively applied to WP SAML Auth configuration."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:164
#: inc/class-wp-saml-auth-settings.php:163
msgid "Some required settings don't have values, so WP SAML Auth isn't active."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:185
#: inc/class-wp-saml-auth-settings.php:184
msgid "Settings"
msgstr ""

#. translators: Field label.
#: inc/class-wp-saml-auth-settings.php:216
#: inc/class-wp-saml-auth-settings.php:215
msgid "%s is a required field"
msgstr ""

#. translators: Field label.
#: inc/class-wp-saml-auth-settings.php:240
#: inc/class-wp-saml-auth-settings.php:239
msgid "%s is not a valid URL."
msgstr ""

#. translators: Field label.
#: inc/class-wp-saml-auth-settings.php:254
#: inc/class-wp-saml-auth-settings.php:253
msgid "%s is not a valid certificate path."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:294
#: inc/class-wp-saml-auth-settings.php:293
msgid "Service Provider Settings"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:295
#: inc/class-wp-saml-auth-settings.php:294
msgid "Identity Provider Settings"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:296
#: inc/class-wp-saml-auth-settings.php:295
msgid "Attribute Mappings"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:312
#: inc/class-wp-saml-auth-settings.php:311
msgid "Auto Provision"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:314
#: inc/class-wp-saml-auth-settings.php:313
msgid "If checked, create a new WordPress user upon login. <br>If unchecked, WordPress user will already need to exist in order to log in."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:320
#: inc/class-wp-saml-auth-settings.php:319
msgid "Permit WordPress login"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:322
#: inc/class-wp-saml-auth-settings.php:321
msgid "If checked, WordPress user can also log in with the standard username and password flow."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:328
#: inc/class-wp-saml-auth-settings.php:327
msgid "Get User By"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:334
#: inc/class-wp-saml-auth-settings.php:333
msgid "Attribute by which SAML requests are matched to WordPress users."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:340
#: inc/class-wp-saml-auth-settings.php:339
msgid "Base URL"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:342
#: inc/class-wp-saml-auth-settings.php:341
msgid "The base url to be used when constructing URLs."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:349
#: inc/class-wp-saml-auth-settings.php:369
#: inc/class-wp-saml-auth-settings.php:348
#: inc/class-wp-saml-auth-settings.php:368
msgid "Entity Id (Required)"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:352
#: inc/class-wp-saml-auth-settings.php:351
msgid "SP (WordPress) entity identifier."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:359
#: inc/class-wp-saml-auth-settings.php:358
msgid "Assertion Consumer Service URL (Required)"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:361
#: inc/class-wp-saml-auth-settings.php:360
msgid "URL where the response from the IdP should be returned (usually the login URL)."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:371
#: inc/class-wp-saml-auth-settings.php:370
msgid "IdP entity identifier."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:377
#: inc/class-wp-saml-auth-settings.php:376
msgid "Single SignOn Service URL (Required)"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:379
#: inc/class-wp-saml-auth-settings.php:378
msgid "URL of the IdP where the SP (WordPress) will send the authentication request."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:385
#: inc/class-wp-saml-auth-settings.php:384
msgid "Single Logout Service URL"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:387
#: inc/class-wp-saml-auth-settings.php:386
msgid "URL of the IdP where the SP (WordPress) will send the signout request."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:392
#: inc/class-wp-saml-auth-settings.php:391
msgid "x509 Cerificate Path"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:394
#: inc/class-wp-saml-auth-settings.php:393
msgid "Path to the x509 certificate file, used for verifying the request.<br/>Include <code>ABSPATH</code> to set path base to WordPress' ABSPATH constant."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:399
#: inc/class-wp-saml-auth-settings.php:398
msgid "Certificate Fingerprint"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:401
#: inc/class-wp-saml-auth-settings.php:400
msgid "If not using x509 certificate, paste the certificate fingerprint and specify the fingerprint algorithm below."
msgstr ""

#: inc/class-wp-saml-auth-settings.php:406
#: inc/class-wp-saml-auth-settings.php:405
msgid "Certificate Fingerprint Algorithm"
msgstr ""

#: inc/class-wp-saml-auth-settings.php:409
#: inc/class-wp-saml-auth-settings.php:408
msgid "N/A"
msgstr ""

#. Translators: Links to the WP SAML Auth plugin.
#: inc/class-wp-saml-auth.php:83
msgid "WP SAML Auth wasn't able to find the <code>OneLogin\\Saml2\\Auth</code> class. Please verify your Composer autoloader, or <a href='%s'>visit the plugin page</a> for more information."
msgstr ""

#. Translators: Links to the WP SAML Auth plugin.
#: inc/class-wp-saml-auth.php:109
msgid "WP SAML Auth wasn't able to find the <code>%1$s</code> class. Please check the <code>simplesamlphp_autoload</code> configuration option, or <a href='%2$s'>visit the plugin page</a> for more information."
msgstr ""

#: inc/class-wp-saml-auth.php:158
msgid "Use one-click authentication:"
msgstr ""

#: inc/class-wp-saml-auth.php:159
msgid "Sign In"
msgstr ""

#: inc/class-wp-saml-auth.php:160
msgid "Or, sign in with WordPress:"
msgstr ""

#. Translators: Includes error reason from OneLogin.
#: inc/class-wp-saml-auth.php:244
msgid "User is not authenticated with SAML IdP. Reason: %s"
msgstr ""

#: inc/class-wp-saml-auth.php:290
msgid "Invalid provider specified for SAML authentication"
msgstr ""

#: inc/class-wp-saml-auth.php:315
msgid "No attributes were present in SAML response. Attributes are used to create and fetch users. Please contact your administrator"
msgstr ""

#. Translators: Communicates how the user is fetched based on the SAML response.
#: inc/class-wp-saml-auth.php:322
msgid "\"%1$s\" attribute is expected, but missing, in SAML response. Attribute is used to fetch existing user by \"%2$s\". Please contact your administrator."
msgstr ""

#: inc/class-wp-saml-auth.php:337
msgid "No WordPress user exists for your account. Please contact your administrator."
msgstr ""
5 changes: 4 additions & 1 deletion readme.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Contributors: getpantheon, danielbachhuber, Outlandish Josh
Tags: authentication, SAML
Requires at least: 4.4
Tested up to: 5.3
Stable tag: 0.8.2
Stable tag: 0.8.3
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html

Expand Down Expand Up @@ -277,6 +277,9 @@ There is no third step. Because SimpleSAMLphp loads WordPress, which has WP Nati

== Changelog ==

= 0.8.3 (February 3, 2020) =
* Removes unused `placeholder` value that's causing PHP notices [[#178](https://github.com/pantheon-systems/wp-saml-auth/pull/178)].

= 0.8.2 (January 22, 2020) =
* Fixes method declaration for methods used statically [[#176](https://github.com/pantheon-systems/wp-saml-auth/pull/176)].

Expand Down
2 changes: 1 addition & 1 deletion wp-saml-auth.php
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
/**
* Plugin Name: WP SAML Auth
* Version: 0.8.1
* Version: 0.8.3
* Description: SAML authentication for WordPress, using SimpleSAMLphp.
* Author: Pantheon
* Author URI: https://pantheon.io
Expand Down

0 comments on commit 7696ff8

Please sign in to comment.