More backwards compatibility fixes and lint tests returned

php/commands/organizations.php

@@ -52,25 +52,25 @@ public function sites($args, $assoc_args) {
       $orgs[$id] = $org->name;
     }
 
-    if (!isset($assoc_args['org'])) {
+    if (!isset($assoc_args['org']) OR empty($assoc_args['org'])) {
       $selected_org = Terminus::menu($orgs,false,"Choose an organization");
     } else {
-      $selected_org = @$assoc_args['org'];
+      $selected_org = $assoc_args['org'];
     }
 
     $org = new Organization($selected_org);
 
-    if (@$assoc_args['add']) {
-        $add = SiteFactory::instance(@$assoc_args['add']);
+    if (isset($assoc_args['add']) {
+        $add = SiteFactory::instance($assoc_args['add']);
 
         Terminus::confirm("Are you sure you want to add %s to %s ?", $assoc_args, array($add->getName(), $org->name));
         $org->addSite($add);
         Terminus::success("Added site!");
         return true;
     }
 
-    if (@$assoc_args['remove']) {
-      $remove = SiteFactory::instance(@$assoc_args['remove']);
+    if (isset($assoc_args['remove'])) {
+      $remove = SiteFactory::instance($assoc_args['remove']);
 
       Terminus::confirm("Are you sure you want to remove %s to %s ?", $assoc_args, array($remove->getName(), $org->name));
       $org->removeSite($remove);
@@ -83,8 +83,8 @@ public function sites($args, $assoc_args) {
     foreach ($sites as $site) {
       $data[] = array(
         'name' => $site->name,
-        'service level' => @$site->service_level,
-        'framework' => @$site->framework,
+        'service level' => $site->service_level,
+        'framework' => $site->framework,
         'created' => date('Y-m-d H:i:s', $site->created),
       );
     }

php/commands/site.php

@@ -1068,7 +1068,7 @@ public function upstream_updates($args, $assoc_args) {
        }
      }
 
-     if (isset($assoc_args['update']) AND !empty(@$upstream->update_log)) {
+     if (isset($assoc_args['update']) AND !empty($upstream->update_log)) {
        $env = 'dev';
        Terminus::confirm(sprintf("Are you sure you want to apply the upstream updates to %s-dev", $site->getName(), $env));
        $response = $site->applyUpstreamUpdates($env);

scripts/test.sh

@@ -3,7 +3,7 @@
 set -ex
 
 # Basic lint test
-#for f in $( git diff-tree $TRAVIS_COMMIT --name-status -r | grep php | grep -v "^D" | awk '{print $2}') ; do php -l $f ; done
+for f in $( git diff-tree $TRAVIS_COMMIT --name-status -r | grep php | grep -v "^D" | awk '{print $2}') ; do php -l $f ; done
 
 # Run the unit tests
 # phpunit