Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jeli 93] Fix fatal error on "Post Schema" page #197

Merged
merged 4 commits into from
Nov 15, 2024
Merged

[Jeli 93] Fix fatal error on "Post Schema" page #197

merged 4 commits into from
Nov 15, 2024

Conversation

stovak
Copy link
Member

@stovak stovak commented Nov 15, 2024

Following deploying #195, the response from the solr server changed now that config was being written to disk as part of the reload core. This changed the behavior of pantheonGuzzle->getQueryResult in certain cases which resulted in a fatal error at /admin/config/search/search-api/server/pantheon_solr8/pantheon-admin.

@stovak stovak requested a review from a team as a code owner November 15, 2024 20:17
@stovak stovak changed the title Jeli 93 ii [Jeli 93] Fix fatal error on "Post Schema" page Nov 15, 2024
pwtyler
pwtyler previously approved these changes Nov 15, 2024
@pwtyler
Copy link
Member

pwtyler commented Nov 15, 2024

Curious. Why was Tom's approval accepted yesterday, but not RJ's here?

@pwtyler pwtyler dismissed their stale review November 15, 2024 21:14

moving fast and breaking things.

Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested c4ca506 on demo site and asserted no longer fatal error.

Copy link
Member

@Hornswoggles Hornswoggles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rkanson rkanson self-requested a review November 15, 2024 21:43
@pwtyler pwtyler merged commit 27d9fbd into 8.x Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants