typos and other proofreading fixes #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CdrMarks
reviewed
Dec 8, 2021
| @@ -46,7 +46,7 @@ and [Search API Solr](https://www.drupal.org/project/search_api_solr) on [Panthe | |||
| Search API Solr provides the ability to connect to any Solr server by providing numerous configuration options. | |||
| This module automatically sets the Solr connection options by extending the plugin from Search API Solr. | |||
| The module also changes its connection information based on different Pantheon environments and each | |||
| Pantheon Environment has it's own [SOLR CORE](). Doing so eliminates the need to do extra work setting up Solr servers for each environment. | |||
| Pantheon Environment has it's own [SOLR CORE](#). Doing so eliminates the need to do extra work setting up Solr servers for each environment. | |||
There was a problem hiding this comment.
I leave that to @stovak but it could be:
Suggested change
| Pantheon Environment has it's own [SOLR CORE](#). Doing so eliminates the need to do extra work setting up Solr servers for each environment. | |
| Pantheon Environment has it's own [Solr Core](#). Doing so eliminates the need to do extra work setting up Solr servers for each environment. |
Without a link there, it was hard for me to know for sure with no source to check.
|
The rest of the changes look good to me. |
|
Actually, in working through the readme, a lot of the stuff in the Search the Index section is confusing to me (partially because I'm new to Drupal). I think I am going to open a new issue just for that feedback. |
in addition to these changes: * in **Search the index**: * "In addition to the fields you added to the index, choose 'relevance' to add[ed] to the results." -- this sounds weird, can this be rephrased? * "Expose any keywords to the user to change and the view will put a KEYWORDS" -- put a KEYWORDS what? put it where?
the actual button is not all caps
|
@jazzsequence Ok to merge when tests pass. As of this moment there's a status incident where actions and tests aren't working on Github or I would have merged tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the readme with some typo, consistency and other proofreading fixes.
in addition to these changes, I've opened a new issue for further clarification in the "Search the index" section of the Readme, which is confusing and unclear to me: #131