Port should always be an integer

pantheon-systems · Feb 4, 2025 · 0889f3c · 0889f3c
1 parent ce655ae
commit 0889f3c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/Plugin/SolrConnector/PantheonSolrConnector.php b/src/Plugin/SolrConnector/PantheonSolrConnector.php
@@ -122,7 +122,7 @@ public static function getPlatformConfig() {
     return [
       'scheme' => getenv('PANTHEON_INDEX_SCHEME'),
       'host' => getenv('PANTHEON_INDEX_HOST'),
-      'port' => getenv('PANTHEON_INDEX_PORT'),
+      'port' => intval(getenv('PANTHEON_INDEX_PORT')),
       'path' => getenv('PANTHEON_INDEX_PATH'),
       'core' => getenv('PANTHEON_INDEX_CORE'),
       'schema' => getenv('PANTHEON_INDEX_SCHEMA'),

diff --git a/tests/Unit/EndpointServiceTest.php b/tests/Unit/EndpointServiceTest.php
@@ -22,7 +22,7 @@ public function testURIGeneration() {
     $ep = new Endpoint([
       'scheme' => 'one',
       'host' => 'two',
-      'port' => '1234',
+      'port' => 1234,
       'path' => 'server-path',
       'core' => '/core-name',
       'schema' => '/schema-path',
@@ -34,7 +34,8 @@ public function testURIGeneration() {
     $this->assertEquals('/core-name', $ep->getCore());
     $this->assertEquals('server-path', $ep->getPath());
     $this->assertEquals('one', $ep->getScheme());
-    $this->assertEquals('1234', $ep->getPort());
+    // If port is a string in the test, it should be an integer.
+    $this->assertEquals(1234, $ep->getPort());
     $this->assertEquals('one://two:1234/', $ep->getBaseUri());
     $this->assertEquals(
       'one://two:1234/server-path/core-name/',