Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pcc 1752 article url from content structure #332

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Pcc 1752 article url from content structure #332

wants to merge 34 commits into from

Conversation

renjithvwarrier
Copy link

No description provided.

@renjithvwarrier
Renjith | Add content structure to article path
3461eb8
@renjithvwarrier
Renjith
ebb868b
@renjithvwarrier
Renjith | Fix tests and add another test to test the ability to map c…
d25c69e 
…ontent struture to URLs
@renjithvwarrier
Renjith
6d753f7
@renjithvwarrier
Renjith | Add content strucutre path to nextjs-starter-approuter-ts s…
728fa37 
…tarter
@renjithvwarrier
Renjith | Update comments on articles url
b776b42
@renjithvwarrier
Renjith | Update tests in nextjs-starter-ts
f36000b
@renjithvwarrier
Refactor site fetching in Next.js starter to remove environment varia…
ce7ae8d 
…ble dependency

- Updated multiple components to call `PCCConvenienceFunctions.getSite()` without passing `process.env.PCC_SITE_ID`.
- Simplified the condition check in `getArticlePathFromContentStructure` function.
- Enhanced the `ArticlesListTemplate` to pass the `site` prop to `ArticleGrid`.
- Consolidated imports in `ssg-isr` examples for better readability.
@renjithvwarrier renjithvwarrier requested a review from a team as a code owner January 20, 2025 07:15
kevinstubbs
kevinstubbs requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@kevinstubbs kevinstubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a changeset
pnpm changeset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinstubbs kevinstubbs kevinstubbs approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renjithvwarrier @kevinstubbs